Update for VS2019 #92
Conversation
cogwheel
force-pushed
the
vs2019-new
branch
4 times, most recently
from
b695ba9 to
1885cd4
Compare
|
@davidc604 I've been working with someone from Appveyor and the failure is due to a missing component on their end. I've successfully tested a build by remoting into the build machine, installing the missing component, and continuing the build. So once appveyor/ci#3058 is addressed it'll work. |
cogwheel
force-pushed
the
vs2019-new
branch
2 times, most recently
from
5e4ccb5 to
405497a
Compare
davidc604
left a comment
davidc604
left a comment
There was a problem hiding this comment.
Reviewed 2 of 3 files at r1, 1 of 1 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @cogwheel)
README.md, line 57 at r2 (raw file):
* [CMake](https://cmake.org/download/) * [OBS dependencies](https://obsproject.com/downloads/dependencies2017.zip) - **TODO** This is only used for libcurl. We should use something else * [Pre-built WebRTC](https://github.com/caffeinetv/webrtc/releases/latest)
just curious, going forward are we going be providing our own flavor of .gn files or scripts for setting up and building the necessary pieces of webrtc that is needed for libcaffeine?
(if we're already doing that then just ignore me...
cogwheel
left a comment
cogwheel
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! all files reviewed, all discussions resolved
README.md, line 57 at r2 (raw file):
Previously, davidc604 (David C) wrote…
just curious, going forward are we going be providing our own flavor of
.gnfiles or scripts for setting up and building the necessary pieces of webrtc that is needed for libcaffeine?(if we're already doing that then just ignore me...
My hope was to keep the WebRTC build as vanilla as possible, so for now I'm just building the webrtc target like normal. I think there are some things it's building that don't need to be linked in though, so I may revisit that at some point to reduce the binary size.
2 participants
This supersedes #91 which is currently in a bugged state (leaving that open for Github to investigate)
This change is